Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fastify doc and quickstart #1555

Merged
merged 17 commits into from
Sep 27, 2024
Merged

update fastify doc and quickstart #1555

merged 17 commits into from
Sep 27, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Sep 19, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

This PR:

  • refactors the setup instructions
  • updates code examples
  • adds important notes about setup

Todo

  • [Done] Clerk Dashboard > Configure > Quick Copy dropdown does not have a Fastify option
  • [Done] Pending access request to Linear Design team, need to make ticket to get Fastify icon for <TutorialHero/>
  • [Done] Repo name needs to be updated to clerk-fastify-quickstart

Notes

  • Updated quickstart
  • Unsure if previous starter repo worked since there was no tsconfig.json file to run server
  • Is it necessary to have a Clerk Fastify doc to show getAuth() method? E.g., Remix
  • Is the ESM note about package.json is necessary?

@victoriaxyz victoriaxyz requested a review from a team as a code owner September 19, 2024 22:41
@victoriaxyz victoriaxyz mentioned this pull request Sep 19, 2024
Merged
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1555

@victoriaxyz victoriaxyz mentioned this pull request Sep 23, 2024
Merged
alexisintech
alexisintech reviewed Sep 25, 2024
View reviewed changes
docs/quickstarts/fastify.mdx Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
alexisintech
alexisintech reviewed Sep 26, 2024
View reviewed changes
docs/quickstarts/fastify.mdx Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
docs/quickstarts/fastify.mdx Outdated Show resolved Hide resolved
@alexisintech alexisintech merged commit 53d766c into main Sep 27, 2024
4 checks passed
@alexisintech alexisintech deleted the vi/docs-9228/fastify-import-order branch September 27, 2024 16:14
royanger pushed a commit that referenced this pull request Oct 8, 2024
@victoriaxyz @alexisintech @royanger
update fastify doc and quickstart (#1555)
3c34ad2 
Co-authored-by: Alexis Aguilar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisintech alexisintech alexisintech approved these changes

@bradlc bradlc Awaiting requested review from bradlc

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victoriaxyz @bradlc @alexisintech @wobsoriano